What should we do with outdated benchmarks?

bmarkons · June 30, 2017, 11:43am

For example here :

ruby-bench/ruby-bench-suite/blob/master/rails/benchmarks/bm_scaffold_show.rb#L45




Rails.application.routes.draw do
resources :posts
end


class Post < ActiveRecord::Base; end


ActionController::Base.prepend_view_path File.expand_path("../views", __FILE__)


class PostsController < ActionController::Base
if Rails.version > '2.3.8'
  before_action :set_post, only: [:show]
else
  before_filter :set_post, only: [:show]
end


# GET /posts/1
# GET /posts/1.json
def show
end

before_filter is deprecated syntax in rails 5. Therefore this should be replaced with before_action.
Assuming we want to run suite for previous rails versions (which I think we do) - do you have any good idea how to handle these differences?

In this specific case we can add one condition :

if Rails::VERSION < 5
  before_filter
else
  before_action
end

But assuming we have lot of those specific conditions, maybe better solution would be to have these separated in subfolders.

Thoughts?

noahgibbs · June 30, 2017, 3:09pm

Off the top of my head… I think a conditional like that is great in this case. I think we probably want to have a range of Rails versions we support, and for anything older than that, we can drop the conditional.

That wouldn’t work with a huge change in Rails API like between Rails 2 and Rails 3. But I don’t know of anything huge like that coming up any year soon…

bmarkons · July 3, 2017, 8:49am

Thanks Noah, I will stick to conditional then.

Topic		Replies	Views
Can we fill up our benchmarks?	12	2344	September 7, 2017
Can we run rubybench benchmarks for rails 7.x?	0	375	December 21, 2022
Comparison of values for Ruby releases	1	1566	January 28, 2015
Esay way to compare Meta	1	1659	September 13, 2017
Rails Micro Benchmarks!	11	3537	June 2, 2015

What should we do with outdated benchmarks?

Related topics