Can we get Rails 3.X stable backfilled

[sam]

@system noticed we are missing Rails 3.X stable benches, can we get them backfilled?

[tenderlove]

I’d also like to contribute a benchmark. I went here but couldn’t find the benchmark for object allocation on record save.

[system]

Will this work?

ruby-bench/ruby-bench-suite/blob/master/rails/benchmarks/bm_activerecord_save.rb

@sam I removed Rails 3 benchmarks sometime back because for many of the benchmarks we had to account for the API changes from 3 to 4. And that was painful to deal with. Are Rails 3 benchmarks still useful?

[tenderlove]

@tgxworld ya, that’s the one. Thank you!

[sam]

@system

I removed Rails 3 benchmarks sometime back because for many of the benchmarks we had to account for the API changes from 3 to 4. And that was painful to deal with. Are Rails 3 benchmarks still useful?

Yeah, I follow, maybe allow bench script to flag that they are compatible with rails 3 and skip incompatible ones. I do want to highlight some of the big perf regressions in Rails 4

[system]

@tenderlove Do you want a benchmark on save that adds more columns?

[system]

Which are the benchmarks that you’re interested to have it backfilled for Rails 3?

[tenderlove]

@system Ya, I’d like to add a benchmark that has more columns and fills them in with strings. It would be cool if we could get the allocations (in memory size, not number) for an AR object.

[system]

@tenderlove

Ya, I’d like to add a benchmark that has more columns and fills them in with strings.

Ok I’ll add that in and start backfilling tomorrow.

[system]

Done backfilling

http://rubybench.org/rails/rails/commits?result_type=activerecord/postgres_create_string_columns&display_count=2000

@tenderlove

It would be cool if we could get the allocations (in memory size, not number) for an AR object.

I’ll add this to my list but it won’t be available soon since we’ll have to backfill all the benchmark for this.